tests(lantern): remove devtools log from tests #16050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjclark
commented
Jun 7, 2024
| @@ -971,8 +971,24 @@ class PageDependencyGraph { | |||
| // above. | |||
| lanternRequests.sort((a, b) => a.rendererStartTime - b.rendererStartTime); | |||
|
|
|||
| // URL defines the initial request that the Lantern graph starts at (the root node) and the | |||
| // main document request. These are equal if there are no redirects. | |||
There was a problem hiding this comment.
will eventually figure out how to derive these two urls from the trace and remove URL as a param.
right now the fallback code here is not smart enough to detect client redirects (b/c that is not represented in our network model), so it is up to the caller to pass in the right urls
bfdf00d
to
7b9f4c5
Compare
7b9f4c5
to
e82949d
Compare
adamraine
approved these changes
Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref #15841
Removes all the devtools log from core/tests/lantern, which at this point was only being used to derive a
URL.