Page MenuHomeFreeBSD
Differential D40578

tcpdump: Reconnect pfsync printer
ClosedPublic
Actions

Authored by jrm on Jun 16 2023, 2:39 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Nov 25, 12:32 AM
Unknown Object (File)
Sun, Nov 24, 8:03 AM
Unknown Object (File)
Oct 19 2024, 9:55 PM
Unknown Object (File)
Oct 19 2024, 9:55 PM
Unknown Object (File)
Oct 19 2024, 9:55 PM
Unknown Object (File)
Oct 19 2024, 9:35 PM
Unknown Object (File)
Oct 1 2024, 9:26 AM
Unknown Object (File)
Oct 1 2024, 9:21 AM
View All 50 Files
Subscribers
imp

Details

Reviewers
kp
emaste
Commits
rG1ad8d2ee1f7d: tcpdump: Reconnect pfsync printer
Summary

Fixes: ee67461e (tpcdump: Update to 4.99.4)

Test Plan

It looks like I missed hooking in the pfsync printer in ee67461e. I think I messed up when redoing the sub-tree merge of vendor/tcpdump to contrib/tcpdump after 4bf98559. This is the only test I've done so far.

make -C /usr/src/usr.sbin/tcpdump clean
make -C /usr/src/usr.sbin/tcpdump
make -C /usr/src/usr.sbin/tcpdump install
sudo /usr/sbin/tcpdump -i pfsync0

After restarting pf, tcpdump shows

tcpdump: verbose output suppressed, use -v[v]... for full protocol decode
listening on pfsync0, link-type PFSYNC (Packet filter state syncing), snapshot length 262144 bytes
19:47:11.484907 19:47:11.484907 PFSYNCv5 len 48
    clear all count 1
    eof count 1^J

Any suggestions for further tests?

Diff Detail

Repository
rG FreeBSD src repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

jrm created this revision.Jun 16 2023, 2:39 PM
Herald added a subscriber: imp. · View Herald TranscriptJun 16 2023, 2:39 PM
jrm requested review of this revision.Jun 16 2023, 2:39 PM
Harbormaster completed remote builds in B52105: Diff 123340.Jun 16 2023, 2:39 PM
jrm edited the test plan for this revision. (Show Details)Jun 16 2023, 8:02 PM
jrm edited the test plan for this revision. (Show Details)
jrm edited the test plan for this revision. (Show Details)
jrm edited the test plan for this revision. (Show Details)
jrm added reviewers: kp, emaste.
kp accepted this revision.Jun 17 2023, 7:54 AM
This revision is now accepted and ready to land.Jun 17 2023, 7:54 AM
Closed by commit rG1ad8d2ee1f7d: tcpdump: Reconnect pfsync printer (authored by jrm). · Explain WhyJun 17 2023, 10:06 AM
This revision was automatically updated to reflect the committed changes.
jrm added a commit: rG1ad8d2ee1f7d: tcpdump: Reconnect pfsync printer.

Revision Contents
Changeset List

PathSize
contrib/
tcpdump/
2 lines
4 lines
3 lines

Diff 123363

View Options

contrib/tcpdump/netdissect.h

Loading...
View Options

contrib/tcpdump/print-pfsync.c

Loading...
View Options

contrib/tcpdump/print.c

Loading...
  翻译：