Last updated on Aug 5, 2024

You're faced with vague feedback on your code changes. How do you decipher and improve upon it?

Receiving vague feedback on your code can be as perplexing as debugging a cryptic error message. You've just pushed a commit, and the response from your team is less than clear. "This could be better," or "It's not quite there yet," they say, leaving you to wonder what exactly 'better' or 'there' means. In the world of computer science, where precision is key, such ambiguity can be a significant hurdle. Yet, it's a common scenario, and navigating it is an essential skill for any developer. The goal is not just to decipher the feedback, but to use it as a stepping stone for improvement.

1 Seek Clarification

When faced with vague feedback, your first move should be to seek clarification. Reach out to the person who reviewed your code and ask for specific examples of what they believe needs improvement. It's important to approach this conversation with a mindset of collaboration and learning, rather than defensiveness. Understanding their perspective can provide valuable insights into your coding style and the project's requirements.

Add your perspective

Mustafa Tahir

Mobile App Developer | Flutter
Report contribution
At first, one should decrypt the vague feedback by communicating clearly and concisely. Once done, convert it into a list of steps and focus on one at a time. Try your best approach to solve all the points mentioned and the unclear issues.

Like

Load more contributions

2 Reflect Objectively

Once you've gathered more details, take a step back and reflect on the feedback objectively. Consider the code changes you made and try to view them through the lens of the additional information you've received. Are there patterns in your coding that might not align with the project's coding standards or best practices? Use this reflection time to identify areas where you may have room for growth.

Add your perspective

Rick Duncan
Report contribution
One thing to consider here is to choose your battles, and to "pay back" your colleague for taking time to review your code. There are times when the feedback is reasonable but not high priority to change. E.g., you used 3 lines of code exactly 2 times and the reviewer asks you to pull it into a helper function. This is a gray area for refactoring, the code is fine either way. Hence you could "won't fix" the comment. Consider, though, that your colleague did a thorough review of your code, so you can spend a few minutes and compromise by implementing their suggestion. (Obviously be careful to re-test after making any changes)

Like

3 Research Solutions

With a clearer understanding of the feedback, it's time to research solutions. If the critique was about a particular coding practice or pattern, look up best practices in that area. For example, if your code review mentioned inefficient algorithms, you might study up on algorithm optimization. This research can often lead to discovering new techniques or tools that can enhance your coding skills.

Add your perspective

4 Implement Changes

Armed with new knowledge, begin implementing changes to your code. If the feedback was about a specific section, focus on refining that area. Remember to keep your changes incremental and test thoroughly as you go. Refactoring code can sometimes introduce new issues, so it's crucial to ensure that your improvements don't negatively impact other parts of the project.

Add your perspective

Rick Duncan
Report contribution
ALWAYS ALWAYS ALWAYS re-test after making that last small change...I can't tell you how many significant product regressions that have snuck in due to this.

Like

5 Request Follow-Up

After making revisions, request a follow-up review. This shows that you're proactive about enhancing your work and value the input of your peers. It also provides an opportunity for you to gauge whether your adjustments align with the expectations and if there's anything further that you can refine.

Add your perspective

Tanmay Maheshwari

Ex-SWE Intern'24 @Siemens EDA | 2x LinkedIn Top Voice | Amazon ML Summer School 2024 | Research Intern @TIET | ML/DL
Report contribution
Reach out to the reviewer and ask specific questions to understand their concerns. Break down the feedback into actionable tasks and address each one of them in your code. Further, request follow ups from your senior and make revisions till you reach the end goal. These reviews provide an opportunity to clarify any remaining doubts and ensure that your revisions meet the desired expectations. This iterative process not only enhances your skills but also fosters a collaborative environment.

Like

6 Share Knowledge

Lastly, consider sharing the knowledge you've gained from this experience with your team. If the feedback led you to learn a new coding technique or tool, presenting it to your colleagues could help improve the overall codebase and prevent similar issues in the future. Sharing also fosters a culture of continuous learning and collective growth within your team.

Add your perspective

7 Here’s what else to consider

This is a space to share examples, stories, or insights that don’t fit into any of the previous sections. What else would you like to add?

Add your perspective

You're faced with vague feedback on your code changes. How do you decipher and improve upon it?

1

2

3

4

5

6

7

1 Seek Clarification

2 Reflect Objectively

3 Research Solutions

4 Implement Changes

5 Request Follow-Up

6 Share Knowledge

7 Here’s what else to consider

Computer Science

Rate this article

Thanks for your feedback

More articles on Computer Science

More relevant reading

You're faced with vague feedback on your code changes. How do you decipher and improve upon it?

1

2

3

4

5

6

7

1 Seek Clarification

2 Reflect Objectively

3 Research Solutions

4 Implement Changes

5 Request Follow-Up

6 Share Knowledge

7 Here’s what else to consider

Computer Science

Rate this article

Thanks for your feedback

Explore Other Skills