-
Notifications
You must be signed in to change notification settings - Fork 596
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fireperf: create a random delay before initiating a remote config fetch. #2968
Conversation
Coverage ReportAffected SDKs
Test Logs
NotesHTML coverage reports can be produced locally with Head commit (44dc407b) is created by Prow via merging commits: b9f0ab6 b255861. |
Binary Size ReportAffected SDKs
Test Logs
NotesHead commit (44dc407b) is created by Prow via merging commits: b9f0ab6 b255861. |
firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
Outdated
Show resolved
Hide resolved
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this change @leotianlizhan. Glad to see the changes. I have few comments. PTAL as it permits.
firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
Outdated
Show resolved
Hide resolved
firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
Outdated
Show resolved
Hide resolved
/retest |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thanks for making the changes Leo.
How are you planning to test this? It is important to do some manual testing to make sure we are able fetch the configs in less than 30 seconds and greater than 5 seconds. If you are able to ascertain that, please feel free to merge this change.
firebase-perf/src/main/java/com/google/firebase/perf/config/RemoteConfigManager.java
Show resolved
Hide resolved
2212970
to
b255861
Compare
yes I've done some manual testing and it looks like it works |
Rationale:
This is required to ensure that a remote notification does not trigger multiple config fetches from remote config at the same time. Internal bug reference: b/187985523
iOS version of the same change firebase/firebase-ios-sdk#8593