-
Notifications
You must be signed in to change notification settings - Fork 197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct element click actions list #1779
Conversation
element click is erroneously defined as `«pointer move action, pointer down action, pointer move action».` but should obviously be `«pointer move action, pointer down action, pointer up action».` making use of the pointer up action defined
The pointer id of pointer up action should be "pointer" to match the pointer move and pointer down actions pointer ids
I have associated with a w3c account now |
I tried to revalidate but it still fails. It looks like you have to join the https://www.w3.org/groups/wg/browser-tools-testing/join/ group? (sorry that process is also new to me). |
It's asking me to do a lot of stuff. Is it possible this correction qualifies as "Non substantive"? |
hmm reading https://www.w3.org/2023/Process-20231103/#substantive-change I suspect not since it does change the wording, even if the original is an obvious error. |
maybe it does count since it corrects what seems like a copy paste error which could be a typo... maybe..
|
The section about tracking errata makes me think otherwise. I'm gonna close PR cause it's expecting more than I can give, but please consider this error reported and hopefully someone with privileges can correct it in the appropriate manner. |
jgraham marked as non substantive for IPR from ash-nazg. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine.
Thanks for the patch, it's much appreciated!
Thanks for he correction James! Given it's approved I'm going to land it. Thanks as well for me to you @dten! |
SHA: 8e382d2 Reason: push, by whimboo Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 8e382d2 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 8e382d2 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
SHA: 8e382d2 Reason: push, by pull[bot] Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
element click is erroneously defined as
«pointer move action, pointer down action, pointer move action».
but should obviously be«pointer move action, pointer down action, pointer up action».
making use of the pointer up action definedPreview | Diff