Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct element click actions list #1779

Merged
merged 2 commits into from
Dec 13, 2023
Merged

Correct element click actions list #1779

merged 2 commits into from
Dec 13, 2023

Conversation

dten
Copy link
Contributor

@dten dten commented Dec 6, 2023

element click is erroneously defined as «pointer move action, pointer down action, pointer move action». but should obviously be «pointer move action, pointer down action, pointer up action». making use of the pointer up action defined


Preview | Diff

dten added 2 commits December 6, 2023 18:24
element click is erroneously defined as `«pointer move action, pointer down action, pointer move action».` but should obviously be `«pointer move action, pointer down action, pointer up action».` making use of the pointer up action defined
The pointer id of pointer up action should be "pointer" to match the pointer move and pointer down actions pointer ids
@dten
Copy link
Contributor Author

dten commented Dec 12, 2023

I have associated with a w3c account now

@whimboo
Copy link
Contributor

whimboo commented Dec 12, 2023

I have associated with a w3c account now

I tried to revalidate but it still fails. It looks like you have to join the https://www.w3.org/groups/wg/browser-tools-testing/join/ group? (sorry that process is also new to me).

@dten
Copy link
Contributor Author

dten commented Dec 12, 2023

It's asking me to do a lot of stuff. Is it possible this correction qualifies as "Non substantive"?

@dten
Copy link
Contributor Author

dten commented Dec 12, 2023

hmm reading https://www.w3.org/2023/Process-20231103/#substantive-change I suspect not since it does change the wording, even if the original is an obvious error.

@dten
Copy link
Contributor Author

dten commented Dec 12, 2023

maybe it does count since it corrects what seems like a copy paste error which could be a typo... maybe..

Examples of changes in this class include correcting non-normative examples which clearly conflict with normative requirements, clarifying informative use cases or other non-normative text, fixing typos or grammatical errors where the change does not change requirements.

@dten
Copy link
Contributor Author

dten commented Dec 12, 2023

The section about tracking errata makes me think otherwise. I'm gonna close PR cause it's expecting more than I can give, but please consider this error reported and hopefully someone with privileges can correct it in the appropriate manner.

@dten dten closed this Dec 12, 2023
@jgraham jgraham reopened this Dec 13, 2023
@w3cbot
Copy link

w3cbot commented Dec 13, 2023

jgraham marked as non substantive for IPR from ash-nazg.

Copy link
Member

@jgraham jgraham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine.

Thanks for the patch, it's much appreciated!

@whimboo
Copy link
Contributor

whimboo commented Dec 13, 2023

Thanks for he correction James! Given it's approved I'm going to land it. Thanks as well for me to you @dten!

@whimboo whimboo merged commit 8e382d2 into w3c:master Dec 13, 2023
1 check passed
github-actions bot added a commit that referenced this pull request Dec 13, 2023
SHA: 8e382d2
Reason: push, by whimboo

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to ZRDKPoWeR/webdriver that referenced this pull request Dec 13, 2023
SHA: 8e382d2
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to soloinovator/webdriver that referenced this pull request Dec 14, 2023
SHA: 8e382d2
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions bot added a commit to xjc90s/webdriver that referenced this pull request Dec 14, 2023
SHA: 8e382d2
Reason: push, by pull[bot]

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
  翻译: