Updating to fit with fetch aborting #152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
annevk
reviewed
Sep 7, 2017
xhr.bs
Outdated
| @@ -526,7 +524,7 @@ methods, when invoked, must run these steps: | |||
| <p>Set variables associated with the object as follows: | |||
|
|
|||
| <ul> | |||
| <li><p>Unset the <a><code>send()</code> flag</a>, <a>stop timeout flag</a>, and | |||
| <li><p>Unset the <a><code>send()</code> flag</a>, and | |||
xhr.bs
Outdated
| <li><p>If <var>req</var>'s <a for=request>done flag</a> is unset, then | ||
| <a for=fetch>terminate</a> <a for=/>fetching</a> with reason <i>timeout</i>. | ||
| <li><p>If <var>req</var>'s <a for=request>done flag</a> is unset, then set the | ||
| <a>timed out flag</a>, and <a for=fetch>terminate</a> <a for=/>fetching</a>. |
There was a problem hiding this comment.
Is the rule "use commas if there are more than two things to do"?
There was a problem hiding this comment.
Yeah, or if it's needed because it would get unwieldy somehow.
xhr.bs
Outdated
| within the amount of milliseconds from the | ||
| {{XMLHttpRequest/timeout!!attribute}} attribute value with reason | ||
| <i>timeout</i>. | ||
| <p>If the {{XMLHttpRequest/timeout!!attribute}} attribute value is not zero, set the |
xhr.bs
Outdated
| <i>timeout</i>. | ||
| <p>If the {{XMLHttpRequest/timeout!!attribute}} attribute value is not zero, set the | ||
| <a>timed out flag</a> and <a for=fetch>terminate</a> <a for=/>fetching</a> if it has not | ||
| returned within the amount of milliseconds from the {{XMLHttpRequest/timeout!!attribute}}. |
There was a problem hiding this comment.
I wonder if we should clarify what returned means here. But maybe as a follow-up since that's not your fault.
xhr.bs
Outdated
| @@ -418,7 +416,7 @@ turn causes the <a>use-CORS-preflight flag</a> to be set.) | |||
| <p>To <dfn>terminate the request</dfn>, | |||
| <a for=fetch>terminate</a> the | |||
| <a for=/>fetch</a> algorithm operated by the | |||
| {{XMLHttpRequest}} object with reason <i>fatal</i>. | |||
| {{XMLHttpRequest}} object. | |||
There was a problem hiding this comment.
Maybe inline this algorithm altogether at this point given you're removing 1 of the 3 callsites?
|
@yutakahirano could you please review this as well? Thanks! |
yutakahirano
approved these changes
Sep 8, 2017
xhr.bs
Outdated
| <a event><code>abort</code></a> and exception | ||
| <code>AbortError</code>. | ||
| <li> | ||
| <p>Otherwise, if <var>response</var>'s <a for=response>body</a>'s <a for=body>stream</a> has |
|
Proposed commit message: |
|
I'm happy with that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preview | Diff